client: NoneVerifier UnknownIssuer instead of BadSignature #421
Conversation
The `NoneVerifier` that's used by default if a rustls client config builder is built without a verifier being specified was configured to return `Error::InvalidCertificate(CertificateError::BadSignature` from all of its trait methods. This commit updates the `verify_server_cert` trait method to instead return `Error::InvalidCertificate(CertificateError::UnknownIssuer)`. This will better match what would happen if you configured an empty root certificate store with a real verifier and is perhaps less confusing to debug than an error indicating a cryptographic signature validation error.
|
Alternatively, maybe If the caller must set up a verifier, why not error at build-time instead of verification time with the |
I think I prefer this. Though if that option doesn't eliminate |
|
I started looking at the alternative and unfortunately it's a breaking change: I think my inclination is to file an issue for that, tag it as a breaking change, and then hold for the next rustls update. (Ediit: #422). |
The
NoneVerifierthat's used by default if a rustls client config builder is built without a verifier being specified was configured to returnError::InvalidCertificate(CertificateError::BadSignature)from all of its trait methods.This branch updates the
verify_server_cert()trait method to instead returnError::InvalidCertificate(CertificateError::UnknownIssuer). This will better match what would happen if you configured an empty root certificate store with a real verifier and is perhaps less confusing to debug than an error indicating a cryptographic signature validation error.BadSignatureis still used forverify_tls12_signature()andverify_tls13_signature()where it feels like an appropriate default error. In practice neither of these trait methods come into play inNoneVerifieruse.Resolves #409